Glasgow | ITP May 2025 | Adiyah Farhan | Sprint 3 | Quote Generator App #742
Conversation
… quotes on the page load and "New-quote" button click
AdiyahFarhan
added
the
Needs Review
| @@ -3,13 +3,16 @@ | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <title>Title here</title> | |||
| <script defer src="quotes.js"></script> | |||
There was a problem hiding this comment.
Can you explain why the originally script tag was up on the head tag (not in the bottom of body) and what defer attribute does here?
There was a problem hiding this comment.
If we use <script> tag up on the tag, without the defer attribute then it downloads and executes the script before parsing the complete file. As a result, the script that tries to access the elements in the that haven't been parsed yet, t will return null because the element doesn’t exist in the DOM yet.
But if we use a defer attribute, it will just download the script on the head but executes the script after the is fully parsed. So by adding defer attribute, we can avoid any blocking issues that makes script to behave improperly.
|
Good job! It works as intended and code is well structured. I left a comment. Please have a look! |
day-lee
added
Reviewed
…sn't make any affect in functionality of the app
AdiyahFarhan
added
Needs Review
day-lee
added
Complete
Learners, PR Template
Self checklist
Changelist
Implement the "Quote Generator App" so that It can display one random quote from the array of quotes on page loads and when the user clicks "New Quote" button, a new random quote will be generated.
Questions
No